Search registries with an empty query #1444

umohnani8 · 2018-09-11T20:41:11Z

Adds functionality to search registries implementing the v2
endpoint with an empty query, that is the results will be
all the available images on the registries.
If this is tried with a v1 registry an error will occur.
To search a whole registry, there needs to be a trailing slash
at the end, i.e podman search registry.fedoraproject.org/.

Fixes #1203

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

umohnani8 · 2018-09-11T20:41:24Z

@rhatdan @mheon PTAL

baude · 2018-09-12T01:06:00Z

bot, retest this please

mheon · 2018-09-12T18:54:49Z

cmd/podman/search.go

@@ -345,6 +345,9 @@ func matchesOfficialFilter(filter searchFilterParams, result docker.SearchResult
 }

 func getRegistry(image string) (string, error) {
+	if image[len(image)-1] == '/' {


Maybe use strings.HasSuffix and strings.TrimSuffix here to be absolutely clear what's going on?

Agreed! Fixed

mheon · 2018-09-12T19:39:15Z

LGTM

umohnani8 · 2018-09-12T20:05:40Z

bot, retest this please

umohnani8 · 2018-09-12T20:39:24Z

bot, retest this please

umohnani8 · 2018-09-12T21:24:27Z

Tests are finally green!

TomSweeneyRedHat · 2018-09-12T23:15:07Z

docs/podman-search.1.md

@@ -13,7 +13,9 @@ The user can specify which registry to search by prefixing the registry in the s
 **registires.search** table in the config file - **/etc/containers/registries.conf**.
 The number of results can be limited using the **--limit** flag. If more than one registry
 is being searched, the limit will be applied to each registry. The output can be filtered
-using the **--filter** flag.
+using the **--filter** flag. To get all available images in a registry without a specific
+query, the user can just enter the registry name with a trailing (example **registry.fedoraproject.org/**).


with a trailing ? I think you want '/' or "slash" here..

TomSweeneyRedHat · 2018-09-12T23:17:50Z

docs/podman-search.1.md

-using the **--filter** flag.
+using the **--filter** flag. To get all available images in a registry without a specific
+query, the user can just enter the registry name with a trailing (example **registry.fedoraproject.org/**).
+Note, searching without a query will only work for registries that implement the v2 API.


Down below you say the search only works for v2, but here you're saying it works for v1, but only the query works on v2? I'm a bit confused.

Reworded a bit.

TomSweeneyRedHat · 2018-09-12T23:18:38Z

docs/podman-search.1.md

@@ -13,7 +13,9 @@ The user can specify which registry to search by prefixing the registry in the s
 **registires.search** table in the config file - **/etc/containers/registries.conf**.


registries.search not registires.search

TomSweeneyRedHat · 2018-09-12T23:20:22Z

docs/podman-search.1.md

@@ -13,7 +13,9 @@ The user can specify which registry to search by prefixing the registry in the s
 **registires.search** table in the config file - **/etc/containers/registries.conf**.
 The number of results can be limited using the **--limit** flag. If more than one registry
 is being searched, the limit will be applied to each registry. The output can be filtered
-using the **--filter** flag.
+using the **--filter** flag. To get all available images in a registry without a specific
+query, the user can just enter the registry name with a trailing (example **registry.fedoraproject.org/**).


OK you mention query here, but I don't see query prior. In the command synopsis term is mentioned but no reference to what that is here. Should term be changed to query?

OK, I think I got it. a query would look like registry.fedoraproject.org/fedora vs registry.fedoraproject.org. Are there any wild cards allowed? i.e. registry.fedoraproject.org/f* to get all the images that start with f? Might be nice to expound on that and/or have an example or two. Also 'term' in the synopsis isn't explained anywhere and I think you're allowing multiple registries to be handed in no? I don't recall the syntax, but if multiples are allowed I think that needs to change to something like [term, ...] but would have to look it up.

No we don't allow multiple registries to be handed in. If you just do podman search image then it will try all the registries from your registries.conf file. If you do podman search docker.io/image it will only search docker.io for image. And now if you do podman search myregistry/, it will return all the images it finds in the registry if it is a v2 registry.

TomSweeneyRedHat

I'd prefer the vendoring to be done in a separate PR as I don't think this PR depends on it, but shrug.

rh-atomic-bot · 2018-09-12T23:54:58Z

☔ The latest upstream changes (presumably facab2a) made this pull request unmergeable. Please resolve the merge conflicts.

Picks up changes made to authentication for registry search. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>

Adds functionality to search registries implementing the v2 endpoint with an empty query, that is the results will be all the available images on the registries. If this is tried with a v1 registry an error will occur. To search a whole registry, there needs to be a trailing slash at the end, i.e `podman search registry.fedoraproject.org/`. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>

umohnani8 · 2018-09-13T14:27:14Z

@TomSweeneyRedHat the vendor is important here as it implements the podman search myregistry/ case in the containers/image side.

umohnani8 · 2018-09-13T15:25:09Z

bot, retest this please

rhatdan · 2018-09-13T16:20:38Z

@rh-atomic-bot r+

rh-atomic-bot · 2018-09-13T16:20:38Z

📌 Commit bbcfa3b has been approved by rhatdan

rh-atomic-bot · 2018-09-13T16:20:44Z

⚡ Test exempted: pull fully rebased and already tested.

Adds functionality to search registries implementing the v2 endpoint with an empty query, that is the results will be all the available images on the registries. If this is tried with a v1 registry an error will occur. To search a whole registry, there needs to be a trailing slash at the end, i.e `podman search registry.fedoraproject.org/`. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com> Closes: #1444 Approved by: rhatdan

TomSweeneyRedHat · 2018-09-13T16:55:28Z

@umohnani8 thanks for the revisions, I like what you did! 👍

umohnani8 force-pushed the search branch from a883802 to 188b23f Compare September 11, 2018 22:26

umohnani8 force-pushed the search branch from 188b23f to bc00e07 Compare September 12, 2018 14:48

umohnani8 mentioned this pull request Sep 12, 2018

podman search with "$registry/" should return all images #1203

Closed

umohnani8 force-pushed the search branch 2 times, most recently from db944ca to 8c6da76 Compare September 12, 2018 17:39

mheon reviewed Sep 12, 2018

View reviewed changes

umohnani8 force-pushed the search branch from 8c6da76 to 222be97 Compare September 12, 2018 19:15

TomSweeneyRedHat reviewed Sep 12, 2018

View reviewed changes

umohnani8 added 2 commits September 13, 2018 10:23

Vendor in latest containers/image

34e2874

Picks up changes made to authentication for registry search. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>

umohnani8 force-pushed the search branch from 222be97 to bbcfa3b Compare September 13, 2018 14:24

rh-atomic-bot closed this in 9bc3c9d Sep 13, 2018

umohnani8 deleted the search branch October 27, 2020 14:27

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Search registries with an empty query #1444

Search registries with an empty query #1444

umohnani8 commented Sep 11, 2018

umohnani8 commented Sep 11, 2018

baude commented Sep 12, 2018

mheon Sep 12, 2018

umohnani8 Sep 12, 2018

mheon commented Sep 12, 2018

umohnani8 commented Sep 12, 2018

umohnani8 commented Sep 12, 2018

umohnani8 commented Sep 12, 2018

TomSweeneyRedHat Sep 12, 2018

umohnani8 Sep 13, 2018

TomSweeneyRedHat Sep 12, 2018

umohnani8 Sep 13, 2018

TomSweeneyRedHat Sep 12, 2018

umohnani8 Sep 13, 2018

TomSweeneyRedHat Sep 12, 2018

TomSweeneyRedHat Sep 12, 2018

umohnani8 Sep 13, 2018

TomSweeneyRedHat left a comment

rh-atomic-bot commented Sep 12, 2018

umohnani8 commented Sep 13, 2018

umohnani8 commented Sep 13, 2018

rhatdan commented Sep 13, 2018

rh-atomic-bot commented Sep 13, 2018

rh-atomic-bot commented Sep 13, 2018

TomSweeneyRedHat commented Sep 13, 2018

		@@ -13,7 +13,9 @@ The user can specify which registry to search by prefixing the registry in the s
		registires.search table in the config file - /etc/containers/registries.conf.

Search registries with an empty query #1444

Search registries with an empty query #1444

Conversation

umohnani8 commented Sep 11, 2018

umohnani8 commented Sep 11, 2018

baude commented Sep 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mheon commented Sep 12, 2018

umohnani8 commented Sep 12, 2018

umohnani8 commented Sep 12, 2018

umohnani8 commented Sep 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

rh-atomic-bot commented Sep 12, 2018

umohnani8 commented Sep 13, 2018

umohnani8 commented Sep 13, 2018

rhatdan commented Sep 13, 2018

rh-atomic-bot commented Sep 13, 2018

rh-atomic-bot commented Sep 13, 2018

TomSweeneyRedHat commented Sep 13, 2018